New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Firefox] Import new commits? #106
Comments
This particular one isn't much of an "improvement" so much as a workaround for how Firefox dealt with showing the dynamic filtering UI on the side. Anyway, this is what pull requests are for, and AlexVallat has already been making them. |
I haven't seen any pull requests from Alex to this fork, only to Chris'. And personally, I would like to keep using @gorhill's version, even for Firefox. It is my understanding that you don't need to wait for a pull request, you can fetch commits from another repo. Hence my question. Regarding 'improvement or fixes' vs 'workaround' I feel that's a bit subjective. Either way, to me that specific change is not important, but rather if @gorhill will be willing to consider some of them in future. |
Funny, this seems to be a point of interest for both factions (just kidding) of uBlock. See here. |
I know all about the development on the other branch, I keep current with it. Please, let's not make this place all noisy again. I will pull whatever I feel like pulling, and when I decide to do so, after evaluating the code/behavior. |
Fair enough, thank you. Just wanted to know what to expect in that regard, not trying to create noise. |
Would you consider to import some of the improvements Alex Vallat might make on the other branch for Firefox version? Not necessarily new features, but improvements or fixes, like this.
Thanks
The text was updated successfully, but these errors were encountered: