Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

###\5f filters not read by uBlock #1668

Closed
ryanbr opened this issue May 29, 2016 · 5 comments
Closed

###\5f filters not read by uBlock #1668

ryanbr opened this issue May 29, 2016 · 5 comments
Labels

Comments

@ryanbr
Copy link
Contributor

ryanbr commented May 29, 2016

\5f iph_cp_popup Isn't read by uO, Because of the "_" being the first character

Open http://blog.hu/ in Firefox/Adblock Plus which hides the cookie element, and then with uBlock which shows the cookie message

@gorhill
Copy link
Owner

gorhill commented May 29, 2016

blog.hu###_iph_cp_popup works fine for both uBO and ABP -- and is easier to parse by humans. Why not use this?

Edit: blog.hu###\_iph_cp_popup also works fine for both uBO and ABP.

@ryanbr
Copy link
Contributor Author

ryanbr commented May 29, 2016

Guessing that css elements shouldn't begin with "_" and maybe other non-standard ascii charaters may break the filters.

@gwarser
Copy link
Contributor

gwarser commented May 29, 2016

@gorhill blog.hu###\_iph_cp_popup works because is specific. Even blog.hu###\5f iph_cp_popup works because is inserted forcibly.

###\_iph_cp_popup not work.

@gwarser
Copy link
Contributor

gwarser commented May 29, 2016

Bit of documentation:

An ID selector contains a "number sign" (U+0023, #) immediately followed by the ID value, which must be an CSS identifiers.

https://www.w3.org/TR/css3-selectors/#id-selectors

identifiers (...) cannot start with a digit, two hyphens, or a hyphen followed by a digit.

https://www.w3.org/TR/CSS21/syndata.html#value-def-identifier

and

Keywords and property names beginning with -' or '_' are reserved for vendor-specific extensions

https://www.w3.org/TR/CSS21/syndata.html#vendor-keywords

@ryanbr
Copy link
Contributor Author

ryanbr commented Oct 30, 2016

Can we get an update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants