New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request: some unused resources are spuriously updated #2594
Comments
Argh, I meant to reference #2592 in my commit. |
Surely you must have it selected. It does not download on my side. |
To be clear, uBO does download only filter lists which are used. The only exception is auxiliary
So this mean only |
I agree, this is a marginal issue, so I see your point about not wanting to change the code for it. As for the AdBlockProtectorList in Firefox using uBO 1.12.1 I see that you added this list on an April 29 commit, whereas 1.12.1 was released on April 15. So perhaps it fetched the new assets.json and decided to fetch this new list too, even though it's not selected in the dashboard. But my Pale Moon has uBO 1.12.3rc0 which was released after the commit, so perhaps that's why it didn't fetch it. |
Ok, I will have a look at the code to find out if this could happen. |
@gorhill please ignore the "edit: it's impossible" comment of mine. It was a mistake. The new list does indeed appear in the 1.12.1 Firefox list but I missed it: It was never selected, though, so my prior comment about commit and release dates may still apply. |
Yes, looking at the update code I see this can happen for asset entries which were added without filter lists being reloaded -- i.e. filter lists reloaded from a snapshot. |
Alright, to fix the AdBlockProtectorList-like issues, I need to play in the code which I did not want to play with, so I will just fix the |
resources.txt
if redirection and injection are both disabled
resources.txt
if redirection and injection are both disabled
I changed the title to be sure there is no misunderstanding -- for the most part uBO was already not updating unused resources. |
|
Force update didn't fetch the new version, so I cleared the cache of the browser and still no change. The copy of resources.txt which received the last update on my end was on April 15th, 2017. It's found in That file doesn't have |
uBO does not write to local file system, the chrome/webext API does not allow this. The version you are looking at is the one shipped with uBO. When it updates a resource, it is saved into chrome/webext API using |
Thank you, very enlightening. So if I delete that file, it would still work fine ? |
It would work fine as long as there is a cached version available. |
I only use the Fanboy Ultimate list, so ideally any list updating would only fetch that list along with assets.json
But starting from a clean browser cache, here's what I see in about:cache after forcing an update.
Pale Moon 27.3
Firefox 53
It would be nice not to fetch resources.txt, as I don't use those (ignoreRedirectFilters = true and ignoreScriptInjectFilters = true). And why is Firefox also retrieving AdBlockProtectorList? I don't have it selected.
My uBO settings are the same for both browsers (but note that I'm on regular Firefox so using v1.12.1 whereas Pale Moon is 1.12.3rc0)
The text was updated successfully, but these errors were encountered: