Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uBO toolbar menu is too wide again. #2709

Closed
streetwolf opened this issue Jun 17, 2017 · 1 comment
Closed

uBO toolbar menu is too wide again. #2709

streetwolf opened this issue Jun 17, 2017 · 1 comment

Comments

@streetwolf
Copy link

streetwolf commented Jun 17, 2017

Not that long ago this was an issue related to Photon and was subsequently fixed. The problem has reappeared on inbound and perhaps Nightly . My original report on the wide menu can be found here: https://bugzilla.mozilla.org/show_bug.cgi?id=1369564. Unlike my original bug report the wide menu also happens if I disable Photon via it's pref.

If you recall another issue I raised here was the extra space on the top and bottom of uBO's menu. At some point it was fixed and I assume you made the change to uBO yourself. There was still a border of white space on the top and bottom but nothing was cut off. Now I notice that the top and bottom appear better looking. Perhaps Mozilla fixed this problem also, maybe causing the wide menu.

The regression range is:

Bad
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ffc1664addf6f15928b3e5382d0061ed9d4f347

Good
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c7ab6f816fa3503240e37653f4ec631674fef23

Running uBlock Origin v1.12.5rc4, windows 10 Pro 64 bit CU, and Fx56 64 bit Inbound.

ubo

@streetwolf
Copy link
Author

Looking good now Ray. What took you so long to fix it? ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant