Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger: generic hiding rule recorded as active when $generichide in effect #2763

Closed
joey04 opened this issue Jul 6, 2017 · 4 comments
Closed
Labels

Comments

@joey04
Copy link

joey04 commented Jul 6, 2017

using 1.13.4 with Fanboy Ultimate list.

Wired.com has a $generichide for the site (from EasyList). So I added a hiding rule that's generic in Fanboy Annoyances because it's obviously not applied in this case.

But when I click on the row in the Logger I see this:

untitled

I'm surprised to see the generic listed alongside my rule in this case. It should only list my rule because of $generichide, right?

@gorhill
Copy link
Owner

gorhill commented Jul 6, 2017

The generic cosmetic filter is not really injected -- the logger is lying. The issue is with the reverse lookup code, it should ignore generic cosmetic filters it finds if they were ignored at injection time.

@gorhill
Copy link
Owner

gorhill commented Dec 31, 2017

Reproducible with the latest dev build

I did not mark the issue as resolved.

@gorhill
Copy link
Owner

gorhill commented Dec 31, 2017

Please no reminder, there are many pages of issues following the first one, I sure wouldn't want to be notified about all of these issues just to be "reminded". I am fully aware of all the issues which are still opened.

@uBlock-user
Copy link
Contributor

Okay, I deleted the posts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants