Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder in logger "Network error" message is not replaced for some locales #2921

Closed
xofe opened this issue Aug 29, 2017 · 2 comments
Closed
Labels

Comments

@xofe
Copy link

xofe commented Aug 29, 2017

Describe the issue

The current English translation uses placeholder {{msg}} in the message errorCantConnectTo, and the code handling this in src/js/assets.js replaces only the string {{msg}}. However, some locales seem to be using an outdated message for errorCantConnectTo that instead uses {{url}} as placeholder, resulting in a broken-looking message appearing in the logger on network error for these locales.

Affected locales: bn, ca, da, el, eo, fa, fi, fil, lv, ml, mr, sl, ta, uk, zh_TW

Note this also affects uMatrix, except there all locales use {{url}}.

Steps for anyone to reproduce the issue

  1. Use (for example) Danish locale version of Firefox.
  2. Open logger with tab selector set to "All".
  3. Open dashboard, block network connections in some way (e.g. firewall), and try to update filters.
  4. See message "Kan ikke forbinde til {{url}}" in logger, with visible placeholder.

Your settings

  • Browser/version: Firefox 56b6, Chromium 62.0.3200
  • uBlock Origin version: 1.13.11rc0
@gorhill
Copy link
Owner

gorhill commented Aug 29, 2017

Just report to Crowdin please, this is where translations are handled, all on a voluntary basis. Since it's all on a voluntary basis, I do not want to badger anyone to contribute more than they wish to on their own accord.

@xofe
Copy link
Author

xofe commented Aug 29, 2017

I don't have a Crowdin account, sorry. I'd say this is also a code issue (especially for uMatrix, where even English is affected), since the code could replace both {{msg}} and {{url}} until translations are updated to prevent breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants