Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pushed out 1.14.0 on Firefox ESR isn't webext compatible #2944

Closed
terr72 opened this issue Sep 1, 2017 · 6 comments
Closed

The pushed out 1.14.0 on Firefox ESR isn't webext compatible #2944

terr72 opened this issue Sep 1, 2017 · 6 comments

Comments

@terr72
Copy link

terr72 commented Sep 1, 2017

Describe the issue

You managed to push out 1.14.0 for Firefox ESR (52.x), which doesn't work with webext-only addons.
When accepting the update, users are being prompted that the addon doesn't work on FF 52.x

Please fix that.
Users with a bit of knowledge are easily able to roll-back by installing 1.13.8, but an average user will get totally confused.

@Mikotochan
Copy link

It seems that the version 1.14.0 claims to be compatible on Firefox 52+ while its beta versions claimed to be compatible on Firefox 54.0+. I guess that this was a mistake and also what caused the upgrade?

@gorhill
Copy link
Owner

gorhill commented Sep 1, 2017

Ok I fixed this in #2945, I did not realized there was an issue opened about this earlier.

I pushed 1.14.4 to AMO, it's pending review.

@stanlane
Copy link

stanlane commented Sep 2, 2017

1.14.4 is on AMO now.

@gorhill
Copy link
Owner

gorhill commented Sep 2, 2017

I was told webext extensions have shorter review time than legacy ones, so it seems this is it.

@stanlane
Copy link

stanlane commented Sep 2, 2017

@gorhill Thank you for sharing this.

@gomoku
Copy link

gomoku commented Sep 2, 2017

@gorhill Some typos in the description?: https://github.com/gorhill/uBlock/releases/tag/1.14.4

Firefox for Android 54
Firefox for Android 55

Not Firefox 54 for Android? Because Android 54 might sound a bit funny as we would been in 2068.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants