Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter not being applied because of $webrtc #3433

Closed
ryanbr opened this issue Jan 13, 2018 · 2 comments
Closed

filter not being applied because of $webrtc #3433

ryanbr opened this issue Jan 13, 2018 · 2 comments

Comments

@ryanbr
Copy link
Contributor

ryanbr commented Jan 13, 2018

Describe the issue

The recent commit; easylist/easylist@3f67895 isn't working in uBo. I believe its related to the webrtc filter.

One or more specific URLs where the issue occurs

hoshsadiq/adblock-nocoin-list#94
https://forums.lanik.us/viewtopic.php?p=130417#p130417

Steps for anyone to reproduce the issue

The following filter isn't being applied properly.

$script,stylesheet,subdocument,third-party,webrtc,websocket,xmlhttprequest,domain=estream.to

The moment I remove $webrtc filter, the filter will work fine.

Your settings

[If you fail to provide this info, I will mark the issue as invalid. Lists all settings which differs from default settings]

  • OS/version: Windows 10
  • Browser/version: Firefox Nightly
  • uBlock Origin version: 1.14.22
Your filter lists

Easylist

@ryanbr
Copy link
Contributor Author

ryanbr commented Jan 13, 2018

I've removed the webrtc switch for the moment, easylist/easylist@d1eb11f Surprised that this is a thing. Can't imagine all the other webrtc filters not being applied

fanboy@host:~/git/easylist/easylist$ grep -r webrtc *.txt | wc -l
132

@gorhill
Copy link
Owner

gorhill commented Jan 13, 2018

Can't imagine all the other webrtc filters not being applied

This requires to unconditionally create a javascript wrapper for all WebRTC stuff content script-side, so it's quite invasive, and if the wrapper itself breaks something legitimate, the only workaround is to disable completely the whole extension (whitelisting is not sufficient).

There has been some actions lately on CSP working group to address the issue of WebRTC not being covered by CSP, so as soon as browsers start to support this, I will make use of it.

For now uBO uses script injection to disable WebRTC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants