Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all images blocked 'Block media elements larger than' set to 0kb #3441

Closed
IOI-655321 opened this issue Jan 16, 2018 · 7 comments
Closed

Comments

@IOI-655321
Copy link

Change the settings 'Block media elements larger than' set to 0kb. No images show generally.

Then go to

https://www.androidauthority.com/best-android-phones-568001/
or
http://www.bbc.co.uk/news

Screenshot in which the issue can be seen

example images

Steps for anyone to reproduce the issue

  1. Change setting in uBlock origin to Block media elements larger than 0kb
  2. Go to https://www.androidauthority.com/best-android-phones-568001/ or http://www.bbc.co.uk/news
  3. See images loaded

Your settings

userSettings": {
"advancedUserEnabled": false,
"alwaysDetachLogger": false,
"autoUpdate": true,
"cloudStorageEnabled": true,
"collapseBlocked": true,
"colorBlindFriendly": false,
"contextMenuEnabled": true,
"dynamicFilteringEnabled": false,
"externalLists": "",
"firewallPaneMinimized": true,
"hyperlinkAuditingDisabled": true,
"ignoreGenericCosmeticFilters": false,
"largeMediaSize": 0,
"parseAllABPHideFilters": true,
"prefetchingDisabled": true,
"requestLogMaxEntries": 1000,
"showIconBadge": true,
"tooltipsDisabled": false,
"webrtcIPAddressHidden": true
}

  • OS/version: Windows 10 Enterprise Version 1703 Build 15063.674
  • Browser/version: Firefox 57.0.4 64 Bit
  • uBlock Origin version: 1.14.24
Your filter lists

"selectedFilterLists": [
"plowe-0",
"disconnect-malware",
"malware-1",
"malware-0",
"disconnect-malvertising",
"easyprivacy",
"adguard-spyware",
"easylist",
"ublock-unbreak",
"ublock-abuse",
"ublock-privacy",
"ublock-badware",
"ublock-filters",
"user-filters"
]

Your custom filters (if any)

Nothing in 'My Filters'

@gorhill
Copy link
Owner

gorhill commented Jan 16, 2018

I can reproduce on FF57, but not on Chromium.

@uBlock-user
Copy link
Contributor

uBlock-user commented Jan 16, 2018

@gorhill On Chromium, every image which is blocked appears twice in the logger once blocked and once unblocked, is that on purpose ?

@gorhill
Copy link
Owner

gorhill commented Jan 16, 2018

It's normal. The images are first seen but not blocked by onBeforeRequest handler, and reported as such in the logger -- so you know that a connection to the remote server occurred.

Then they are blocked once uBO receives the response headers, and reported as such in the logger. It's impossible to block image by size in the onBeforeRequest handler, uBO needs the response headers.

@uBlock-user
Copy link
Contributor

Doesn't happen with fonts when I use Block remote fonts, they only appear once, so it's specific to images only ?

@gorhill
Copy link
Owner

gorhill commented Jan 16, 2018

Fonts can be blocked by onBeforeRequest handler, no need to connect to remote server because no need for response headers.

@uBlock-user
Copy link
Contributor

Another question, checking for size wouldn't be needed if I set the size to 0 kB or is it ?

@gorhill
Copy link
Owner

gorhill commented Jan 16, 2018

#1473 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants