Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not really an issue : impressive improvement of Firefox 41 for AdBlock #427

Closed
Dormann opened this issue Jul 1, 2015 · 4 comments
Closed

Comments

@Dormann
Copy link

Dormann commented Jul 1, 2015

Hello,

Nicholas Nethercote made this news (https://blog.mozilla.org/nnethercote/2015/07/01/firefox-41-will-use-less-memory-when-running-adblock-plus/): it seems they, at long last, patch a very old issue with Firefox, making it lighter in memory usage and also making AdBlock Plus really lighter.
He also said that it would not affect uBlock since it makes things differently.

The questions here are:

  • is there really no gain for uBlock ?
  • could you do another benchmark to show the diffrence in memory use and also in CPU use (maybe also, in time needed to display a web page) ?

It is not like I would switch to AdBlock Plus since I cannot stand their policy.
But I just would like to know.

@SW1FT
Copy link
Contributor

SW1FT commented Jul 1, 2015

No gain for uBlock as it doesn't use the same method to block ads.

@gorhill
Copy link
Owner

gorhill commented Jul 1, 2015

is there really no gain for uBlock

Doubtful, uBlock does not use global stylesheet to enforce cosmetic filtering, and my understanding is that the Firefox fix applies only to global stylesheets.

could you do another benchmark to show the diffrence in memory use and also in CPU use

I will for memory use. You can also try it yourself meanwhile by following very rigorously the steps of the benchmark: https://github.com/gorhill/uBlock/wiki/Firefox-version:-benchmarking-memory-footprint.

However I never performed a benchmark for CPU on Firefox, because I wrote a custom benchmark tool to automate the benchmarks on Chromium, and this tool is not available for Firefox. Using an automated tool ensure the benchmarks are rigorous. Even then, Chromium makes it further easier to measure CPU usage because one can see CPU use specific to an extension in the browser's task manager.

@gorhill
Copy link
Owner

gorhill commented Jul 19, 2015

I can't answer a specific passage on the blog itself, there is no reply button. So here.

@nnethercote

Sometimes it’s worth thinking outside the tech elite bubble [...] and thinking about ordinary users in the real world

That's actually what motivated me to start uBlock more than one year ago, as my answer to the "tech elite bubble" misrepresenting a solution worth investigating for the benefit of users.

@gorhill
Copy link
Owner

gorhill commented Sep 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants