Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI Improvement] Consider adding loading throbbers if loading takes more than X amount of time #461

Closed
Mikey1993 opened this issue Jul 8, 2015 · 6 comments

Comments

@Mikey1993
Copy link
Contributor

As the title says.

On my low end machine (Athlon X4 631 CPU + NVIDIA GeForce GT 520 GPU),
it takes some good 5 seconds to load it in the beginning (while the system, especially the HDD, under some load).

I would suggest adding a spinning throbber only if the loading takes more than X seconds (I think 1 second is OK for the throbber to show) while loading tabs in the dashboard (just like e10s on FF is doing when there is some work that blocks the renderer from showing up the page).

This would tell the user that everything is OK while he is waiting for the page to load.

My lucky guess is that most of the people who use uBlock Origin have some kind of lowish end system, this can be a great perceivable improvement for them for the "first time experience" with uBlock.

@Mikey1993 Mikey1993 changed the title Consider adding loading throbbers if loading takes more than X amount of time [GUI Improvement] Consider adding loading throbbers if loading takes more than X amount of time Jul 8, 2015
@TeddStriker
Copy link

Do you mean adding a throbber when you click the uBlock toolbar button, for the dropdon menu? Or do you meant the logger UI? In any case, I'm running Firefox 39 with uBlock0 on a 8 year old Dell, with a 800MHz Core 2 Duo, with integrated graphics and it runs just fine. Have you tried disabling/enabling hardware acceleration to see if that speeds things up? Sorry in advance if I misunderstood what you were trying to say.

@Mikey1993
Copy link
Contributor Author

@TeddStriker I mean adding a throbber when doing any operation which changes on screen content, and especially I'm taking about going to the dashboard and clicking on the 3rd-party filters tab, which can take a hefty amount of time on a low end machine which is under some load (maybe your HDD is in a good defragmented state, low CPU usage, have a lot of physical memory headroom and etc).

@gorhill
Copy link
Owner

gorhill commented Jul 8, 2015

There is no performance issue. What you may be experiencing is network delay when fetching https://raw.githubusercontent.com/gorhill/uBlock/master/assets/checksums.txt, which is what the 3rd-party filters pane does first, the first time you visit that pane.

@Mikey1993
Copy link
Contributor Author

@gorhill This is quite puzzling, as on my high end PC, which is connected to the same router as the low end PC, I can see this behavior very rarely (and surely not 5 seconds as the low end machine).

In any case, it will be nice to have a throbber to indicate that the page is working on something..

@luxoflux
Copy link

luxoflux commented Jul 8, 2015

As @gorhill said, it's only on the first visit to that pane. But I agree with the suggestion to reduce the appearance of delay — make the whole page slightly opaque before fetching checksums, with or without a loading indicator. Simply for a smoother UX.

@gorhill
Copy link
Owner

gorhill commented Mar 22, 2017

uBO no longer rely on fetching https://raw.githubusercontent.com/gorhill/uBlock/master/assets/checksums.txt when opening the 3rd-party filters pane since assets code was refactored.

@gorhill gorhill closed this as completed Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants