Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

Minor fixes #839

Merged
merged 8 commits into from
Nov 24, 2017
Merged

Minor fixes #839

merged 8 commits into from
Nov 24, 2017

Conversation

xofe
Copy link
Contributor

@xofe xofe commented Nov 24, 2017

This PR contains a handful of minor/trivial fixes for some issues I've noticed. Most of these are patches I've been using in a personal build of uMatrix (and therefore have tested well!), and a few are small fixes/tweaks from uBO.

Each fix is contained in a single commit. Most are unrelated to each other, so if you'd prefer me to create an individual PR for each of them or remove any of them, just let me know.

Fixes:

  • add a bottom border to the logger toolbar, so it doesn't blend in to the logger table entries
  • fade-in tooltips when hovering buttons on the popup, like uBO
  • add missing tooltip for the dashboard link on popup
  • avoid CPU-costly Date.toLocale(Date|Time)String() in logger page (from uBO - gorhill/uBlock@02a79ea)
  • add a favicon to the dashboard/logger pages + add i18n support for the logger title
  • trashcan instead of X to remove an imported list (from uBO - gorhill/uBlock@efffa5e)
  • minor fixes for the firefox and webext build scripts

@gorhill gorhill merged commit d3e789f into gorhill:master Nov 24, 2017
@gorhill
Copy link
Owner

gorhill commented Nov 24, 2017

Looks all good to me, thanks!

@xofe
Copy link
Contributor Author

xofe commented Nov 24, 2017

Glad I could contribute!

@xofe xofe deleted the minor-fixes branch December 11, 2017 18:08
@xofe xofe mentioned this pull request Dec 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants