Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

Support RTL languages #29

Open
gorhill opened this issue Nov 1, 2014 · 10 comments
Open

Support RTL languages #29

gorhill opened this issue Nov 1, 2014 · 10 comments

Comments

@gorhill
Copy link
Owner

gorhill commented Nov 1, 2014

Just like with uBlock, I need to go through all HTML codes to be RTL language-friendly

@Mikey1993
Copy link

This is a blessed move on my part (I am the Hebrew translator on Crowdin), and would be glad to help.

@gorhill
Copy link
Owner Author

gorhill commented Nov 1, 2014

I will use a different approach than with uBlock though, as per @Deathamns' input: using @@bidi_ makes the code non-portable. It can be avoided with a mix of simple CSS/JS.

@Mikey1993
Copy link

Sure thing, I agree.

@gorhill
Copy link
Owner Author

gorhill commented Nov 2, 2014

So I am going to try and fix this today. There are things I am not sure about how it should render for RTL languages, like the matrix:

a

Should the top toolbar be exactly reverse-ordered (i.e. scope selector to the right, etc.), or should I keep the exact same order?

Also, what about the matrix columns, exact same or exact reverse?

gorhill added a commit that referenced this issue Nov 2, 2014
@Mikey1993
Copy link

The top toolbar should be reverse-ordered, e.g. the "mozilla.org" drop down list on the most right, then the power button icon, then the lock icon and so on..

While the matrix columns should be as shown in your image.
Although I see that some of the titles are cut out, is it something you are gonna address?

Thanks for your work!

gorhill added a commit that referenced this issue Nov 3, 2014
@gorhill
Copy link
Owner Author

gorhill commented Nov 5, 2014

Re. "middle". This is what I have on my side when using "he" locale:

a

@Mikey1993
Copy link

Yes, I was silly and didn't update uMatrix to the latest version where you've applied the second patch to this issue - it looks like in your image.

BTW, I am worried about the cut off of some of the headers on the matrix, I have no shorter names or abbreviations for them...
Any thoughts about that?

@Mikey1993
Copy link

Actually... I think that the font that English uses is narrower than the one that is used by Hebrew.
Can we sort this out and ultimately fix the cut off?

@gorhill
Copy link
Owner Author

gorhill commented Nov 6, 2014

Difficult to solve. There is a limit on how wide a popup can be. When using the setting "Large font", the popup is very close to the limit, and we have to be sure we don't beyond this limit, or the matrix will be all broken, i.e. no longer a matrix visually.

@gorhill
Copy link
Owner Author

gorhill commented Nov 6, 2014

I will experiment with CSS transform tricks when I have time, but I won't hold from "shipping" for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants