-
Notifications
You must be signed in to change notification settings - Fork 470
Support RTL languages #29
Comments
This is a blessed move on my part (I am the Hebrew translator on Crowdin), and would be glad to help. |
I will use a different approach than with uBlock though, as per @Deathamns' input: using |
Sure thing, I agree. |
So I am going to try and fix this today. There are things I am not sure about how it should render for RTL languages, like the matrix: Should the top toolbar be exactly reverse-ordered (i.e. scope selector to the right, etc.), or should I keep the exact same order? Also, what about the matrix columns, exact same or exact reverse? |
The top toolbar should be reverse-ordered, e.g. the "mozilla.org" drop down list on the most right, then the power button icon, then the lock icon and so on.. While the matrix columns should be as shown in your image. Thanks for your work! |
Yes, I was silly and didn't update uMatrix to the latest version where you've applied the second patch to this issue - it looks like in your image. BTW, I am worried about the cut off of some of the headers on the matrix, I have no shorter names or abbreviations for them... |
Actually... I think that the font that English uses is narrower than the one that is used by Hebrew. |
Difficult to solve. There is a limit on how wide a popup can be. When using the setting "Large font", the popup is very close to the limit, and we have to be sure we don't beyond this limit, or the matrix will be all broken, i.e. no longer a matrix visually. |
I will experiment with CSS transform tricks when I have time, but I won't hold from "shipping" for now. |
Just like with uBlock, I need to go through all HTML codes to be RTL language-friendly
The text was updated successfully, but these errors were encountered: