Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove nanoid and react-native-redash to clean up some build issues #1046

Merged
merged 2 commits into from Sep 9, 2022

Conversation

natew
Copy link
Contributor

@natew natew commented Aug 1, 2022

redash especially causes build issues, bit cleaned up nanoid while I was there.

@natew
Copy link
Contributor Author

natew commented Aug 1, 2022

Fixes #1020

@gorhom gorhom self-requested a review August 13, 2022 14:06
@gorhom gorhom added the v4 Written in Reanimated v2 label Aug 13, 2022
Copy link
Owner

@gorhom gorhom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @natew for submitting this PR, all looks fine except the removal of invariant package, it is still needed for now

package.json Show resolved Hide resolved
@hirbod
Copy link

hirbod commented Aug 30, 2022

Anything I can do to get this merged? :)

@gorhom gorhom self-assigned this Sep 9, 2022
@gorhom
Copy link
Owner

gorhom commented Sep 9, 2022

thanks @natew for submitting this PR !

@gorhom gorhom merged commit 8fc11fd into gorhom:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 Written in Reanimated v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants