Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resume close animation when container gets resized (#1374) #1392

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

gorhom
Copy link
Owner

@gorhom gorhom commented Jun 4, 2023

Closes #1374

Motivation

In Android when the windowSoftInputMode is set to adjustResize, it will resize the entire the app when the keyboard appears. This causes a conflict with the close position where it set to be the container height.

The fix will ensure that close animation will be corrected whenever the container height gets updated.

@gorhom gorhom added the v4 Written in Reanimated v2 label Jun 4, 2023
@gorhom gorhom changed the title fix: resume close animation when cotnainer gets resized (#1374) fix: resume close animation when container gets resized (#1374) Jun 4, 2023
@gorhom gorhom merged commit 92ad842 into master Jun 4, 2023
@gorhom gorhom deleted the fix/close-animation branch June 4, 2023 15:38
@batuhansahan
Copy link

batuhansahan commented Jun 5, 2023

@gorhom i believe this happens on v5(on IOS) too with the keyboardBlurBehavior="restore". Closing modal with keyboard. Modal itself reopens.

@LuisRego
Copy link

LuisRego commented Jun 27, 2023

@gorhom i believe this happens on v5(on IOS) too with the keyboardBlurBehavior="restore". Closing modal with keyboard. Modal itself reopens.

I was having a similar issue with reanimated@3.x, if we dismiss() the bottom sheet with the keyboard opened it will animate to a snap point instead of the animating to a close position.

@gorhom
Copy link
Owner Author

gorhom commented Jun 27, 2023

I'll pick this fix to v5 later today

@batuhansahan
Copy link

batuhansahan commented Nov 30, 2023

Hello @gorhom is this fixed(it seems not fixed) on v5 i was searching commit history but did not found changes on v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 Written in Reanimated v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v4] Sheet re-opens after closing on Android when keyboard present - only with 100% detent.
3 participants