Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed sheet visibility when handle provided null #224

Merged
merged 1 commit into from
Jan 21, 2021
Merged

fix: fixed sheet visibility when handle provided null #224

merged 1 commit into from
Jan 21, 2021

Conversation

gorhom
Copy link
Owner

@gorhom gorhom commented Jan 21, 2021

closes #217

Motivation

the issue was shouldMeasureHandleHeight marked true when handleComponent is null.

@gorhom gorhom added the v2 Written in Reanimated v1 label Jan 21, 2021
@gorhom gorhom merged commit c32e700 into master Jan 21, 2021
@gorhom gorhom deleted the fix/sheet-visibility-when-handle-is-null branch January 21, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v2 Written in Reanimated v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bottom sheet does not become visible if handleComponent is null
1 participant
@gorhom