Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stabilise animated callback node variables #239

Merged
merged 1 commit into from
Jan 28, 2021
Merged

fix: stabilise animated callback node variables #239

merged 1 commit into from
Jan 28, 2021

Conversation

gorhom
Copy link
Owner

@gorhom gorhom commented Jan 27, 2021 •
edited
Loading

close #208

Motivation

with this pr, animatedIndex and animatedPosition won't be interpolated until the layout is calculated.

Installation

yarn add ssh://git@github.com:gorhom/react-native-bottom-sheet#fix/animated-variables-flickering

@gorhom gorhom added the v2 Written in Reanimated v1 label Jan 27, 2021
@gorhom gorhom mentioned this pull request Jan 27, 2021
Closed
@theohdv
Copy link

theohdv commented Jan 28, 2021

Works perfectly in my case ! Thanks a lot for your reactivity

@gorhom
Copy link
Owner Author

gorhom commented Jan 28, 2021

thanks for testing it @theohdv

@gorhom gorhom merged commit 0444886 into master Jan 28, 2021
@gorhom gorhom deleted the fix/animated-variables-flickering branch January 28, 2021 19:39
@ferrannp ferrannp mentioned this pull request Jan 29, 2021
Closed
@gorhom
Copy link
Owner Author

gorhom commented Jan 29, 2021

this should be fixed with v2.0.7 🎉

@gorhom gorhom mentioned this pull request Feb 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v2 Written in Reanimated v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backdrop flashes on mount
2 participants
@gorhom @theohdv