Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stabilise modal un-mounting #254

Merged
merged 1 commit into from Feb 1, 2021
Merged

fix: stabilise modal un-mounting #254

merged 1 commit into from Feb 1, 2021

Conversation

gorhom
Copy link
Owner

@gorhom gorhom commented Feb 1, 2021

close #252

Motivation

this pr insures that the modal will be unmounted properly then call the onDismiss callback

Installation

yarn add ssh://git@github.com:gorhom/react-native-bottom-sheet#fix/stablise-modal-unmounting

@gorhom gorhom added the v2 Written in Reanimated v1 label Feb 1, 2021
@gorhom
Copy link
Owner Author

gorhom commented Feb 1, 2021

@kickbk could you please test this pr :)

@kickbk
Copy link

kickbk commented Feb 1, 2021

Yup, that fixed it 👍

@gorhom gorhom merged commit 43efd16 into master Feb 1, 2021
@gorhom gorhom deleted the fix/stablise-modal-unmounting branch February 1, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v2 Written in Reanimated v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bottom sheet stops showing when setting state in onDismiss
2 participants
@gorhom @kickbk