fix: backdrop random appearance #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Johan-dutoit could you try this pr :) |
|
Testing this in the bottom sheet example project resulted in the expected behaviour, so LGTM. I do need to see what's happening on my local project though, as it removes all my pointer events (on the contents below, from the initial render)... could just be a bad implementation on my part. |
Johan-dutoit
approved these changes
Mar 30, 2021
|
@Johan-dutoit i think it is better to investigate your usecase, is it possible to provide a sample reproducible snack ? |
|
After further investigation, it was an old bottom sheet that wasn't implemented correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #375
Motivation
For some reason
transformis not stable when component mount then animateInstallation