Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove deep equal checker #395

Merged
merged 2 commits into from
Apr 24, 2021
Merged

Conversation

gorhom
Copy link
Owner

@gorhom gorhom commented Apr 10, 2021

Closes #297

Motivation

This pr will remove the deep equal checker from all the library components due to some issues when integrating with React Navigation.

  • removed lodash isEqual

Installation

yarn add ssh://git@github.com:gorhom/react-native-bottom-sheet#feature/remove-deep-equal-checker

@gorhom gorhom added the v3 Written in Reanimated v2 label Apr 10, 2021
@gorhom gorhom linked an issue Apr 10, 2021 that may be closed by this pull request
@gorhom gorhom merged commit 9f98879 into v3 Apr 24, 2021
@gorhom gorhom deleted the feature/remove-deep-equal-checker branch April 24, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 Written in Reanimated v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bottom-sheet raises warning in react-navigation with deep equal
1 participant