Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor simplifications #467

Merged
merged 1 commit into from
May 31, 2021
Merged

chore: minor simplifications #467

merged 1 commit into from
May 31, 2021

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented May 31, 2021 •
edited

Motivation

this is a tiny PR that

  1. removes GESTURE.UNDETERMINED because it is unused - a gesture is always attached to either the handle or sheet content
  2. simplifies timing animation config creation in a subtle way

I've been using these changes locally for a while and they seem to work fine

@gorhom gorhom added the v4 Written in Reanimated v2 label May 31, 2021
@gorhom
Copy link
Owner

gorhom commented May 31, 2021

thanks @vonovak for submitting this PR 👏

@gorhom gorhom merged commit 7cfe70d into gorhom:v4 May 31, 2021
@vonovak vonovak deleted the chore/simplify branch May 31, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v4 Written in Reanimated v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vonovak @gorhom