Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): replace blacklist with exclusionList #649

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

emadhajjar
Copy link
Contributor

Motivation

The example can't be run

yarn start
yarn run v1.22.5
$ react-native start
error Cannot find module 'metro-config/src/defaults/blacklist'
Require stack:
- .\react-native-bottom-sheet\example\metro.config.js
- .\react-native-bottom-sheet\example\node_modules\import-fresh\index.js
- .\react-native-bottom-sheet\example\node_modules\cosmiconfig\dist\loaders.js
- .\react-native-bottom-sheet\example\node_modules\cosmiconfig\dist\createExplorer.js
- .\react-native-bottom-sheet\example\node_modules\cosmiconfig\dist\index.js
- .\react-native-bottom-sheet\example\node_modules\@react-native-community\cli\build\tools\config\readConfigFromDisk.js
- .\react-native-bottom-sheet\example\node_modules\@react-native-community\cli\build\tools\config\index.js
- .\react-native-bottom-sheet\example\node_modules\@react-native-community\cli\build\commands\install\install.js
- .\react-native-bottom-sheet\example\node_modules\@react-native-community\cli\build\commands\index.js
- .\react-native-bottom-sheet\example\node_modules\@react-native-community\cli\build\index.js
- .\react-native-bottom-sheet\example\node_modules\react-native\cli.js.
Error: Cannot find module 'metro-config/src/defaults/blacklist'
Require stack:
- .\react-native-bottom-sheet\example\metro.config.js
- .\react-native-bottom-sheet\example\node_modules\import-fresh\index.js
- .\react-native-bottom-sheet\example\node_modules\cosmiconfig\dist\loaders.js
- .\react-native-bottom-sheet\example\node_modules\cosmiconfig\dist\createExplorer.js
- .\react-native-bottom-sheet\example\node_modules\cosmiconfig\dist\index.js
- .\react-native-bottom-sheet\example\node_modules\@react-native-community\cli\build\tools\config\readConfigFromDisk.js
- .\react-native-bottom-sheet\example\node_modules\@react-native-community\cli\build\tools\config\index.js
- .\react-native-bottom-sheet\example\node_modules\@react-native-community\cli\build\commands\install\install.js
- .\react-native-bottom-sheet\example\node_modules\@react-native-community\cli\build\commands\index.js
- .\react-native-bottom-sheet\example\node_modules\@react-native-community\cli\build\index.js
- .\react-native-bottom-sheet\example\node_modules\react-native\cli.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:941:15)
    at Function.Module._load (node:internal/modules/cjs/loader:774:27)
    at Module.require (node:internal/modules/cjs/loader:1013:19)
    at require (node:internal/modules/cjs/helpers:93:18)
    at Object.<anonymous> (.\react-native-bottom-sheet\example\metro.config.js:3:19)
    at Module._compile (node:internal/modules/cjs/loader:1109:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1138:10)
    at Module.load (node:internal/modules/cjs/loader:989:32)
    at Function.Module._load (node:internal/modules/cjs/loader:829:14)
    at Module.require (node:internal/modules/cjs/loader:1013:19)
info Run CLI with --verbose flag for more details.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@nidelson
Copy link

Good!
Now it's working!

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@nidelson
Copy link

@gorhom
PT: Como pode fechar PR sem merge?
EN: How can close PR without merge?

Is this repository down?

@gorhom gorhom reopened this Dec 28, 2021
@gorhom gorhom merged commit e3881b3 into gorhom:master Dec 28, 2021
@gorhom
Copy link
Owner

gorhom commented Dec 28, 2021

thanks @aleppos for submitting this PR

@nidelson
Copy link

Thanks @gorhom for excellent component. The community thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants