fix: Always update height to avoid races. #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating a shared values is an asynchronous operation, so if two layouts happen in quick succession, we can miss an update.
|
Quote from the Reanimated docs:
|
elan
force-pushed
the
elan-fix-layout-race
branch
from
9387f8a
to
6120460
Compare
|
@elan thanks for spotting this issue and submitting a PR ! |
jakobo
added a commit
to jakobo/react-native-bottom-sheet
that referenced
this pull request
Apr 22, 2022
…SheetBackdrop_defaults * upstream/master: chore: updated react native portal library fix: always update container height to avoid races. (gorhom#919)(by @elan)
gorhom
added a commit
that referenced
this pull request
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating a shared values is an asynchronous operation, so if two layouts happen in quick succession, we can miss an update.
Please provide enough information so that others can review your pull request:
Motivation
On iOS devices, when backgrounding an app, the OS takes two screenshots (normal, and then rotated) so it can display thumbnail in the app switcher regardless of orientation. Apps see a rather confusing success of two screen rotations (and thus layouts).
What would happen is in some cases (it's a race), the container height would end up changing only once to the landscape height, so when you foregrounded the app again your displayed sheet would suddenly be cropped.
So here's the sheet showing properly (full screen player in Plexamp):
After backgrounding and foregrounding, and missing a change to the shared value: