Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allowed keyboard height to be recalculated when it changes #931

Merged
merged 1 commit into from
May 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 45 additions & 10 deletions src/components/bottomSheet/BottomSheet.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
/**
* Returns keyboard height that in the root container.
*/
const getKeyboardHeightInContainer = useWorkletCallback(() => {
const animatedKeyboardHeightInContainer = useDerivedValue(() => {
/**
* if android software input mode is not `adjustPan`, than keyboard
* height will be 0 all the time.
Expand All @@ -313,7 +313,13 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
: Math.abs(
animatedKeyboardHeight.value - animatedContainerOffset.value.bottom
);
}, [$modal, bottomInset]);
}, [
$modal,
android_keyboardInputMode,
bottomInset,
animatedKeyboardHeight,
animatedContainerOffset,
]);
//#endregion

//#region state/dynamic variables
Expand All @@ -335,7 +341,7 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(

// extended position with keyboard =
// container height - (sheet height + keyboard height in root container)
const keyboardHeightInContainer = getKeyboardHeightInContainer();
const keyboardHeightInContainer = animatedKeyboardHeightInContainer.value;
const extendedPositionWithKeyboard = Math.max(
0,
animatedContainerHeight.value -
Expand All @@ -362,7 +368,15 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
}

return SHEET_STATE.OPENED;
}, [keyboardBehavior]);
}, [
animatedClosedPosition,
animatedContainerHeight,
animatedKeyboardHeightInContainer,
animatedPosition,
animatedSheetHeight,
isInTemporaryPosition,
keyboardBehavior,
]);
const animatedScrollableState = useDerivedValue(() => {
/**
* if scrollable override state is set, then we just return its value.
Expand Down Expand Up @@ -402,7 +416,7 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
});
// dynamic
const animatedContentHeight = useDerivedValue(() => {
const keyboardHeightInContainer = getKeyboardHeightInContainer();
const keyboardHeightInContainer = animatedKeyboardHeightInContainer.value;
const handleHeight = Math.max(0, animatedHandleHeight.value);
let contentHeight = animatedSheetHeight.value - handleHeight;

Expand Down Expand Up @@ -457,7 +471,15 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
* @link (https://github.com/gorhom/react-native-bottom-sheet/issues/470)
*/
return Math.max(contentHeight, 0);
}, [keyboardBehavior]);
}, [
animatedContainerHeight,
animatedHandleHeight,
animatedKeyboardHeightInContainer,
animatedKeyboardState,
animatedSheetHeight,
isInTemporaryPosition,
keyboardBehavior,
]);
const animatedIndex = useDerivedValue(() => {
const adjustedSnapPoints = animatedSnapPoints.value.slice().reverse();
const adjustedSnapPointsIndexes = animatedSnapPoints.value
Expand Down Expand Up @@ -563,7 +585,8 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
keyboardState === KEYBOARD_STATE.SHOWN
) {
isInTemporaryPosition.value = true;
const keyboardHeightInContainer = getKeyboardHeightInContainer();
const keyboardHeightInContainer =
animatedKeyboardHeightInContainer.value;
return Math.max(0, highestSnapPoint - keyboardHeightInContainer);
}

Expand All @@ -573,7 +596,19 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(

return snapPoints[currentIndex];
},
[keyboardBehavior, keyboardBlurBehavior]
[
animatedContentGestureState,
animatedCurrentIndex,
animatedHandleGestureState,
animatedHighestSnapPoint,
animatedKeyboardHeightInContainer,
animatedKeyboardState,
animatedPosition,
animatedSnapPoints,
isInTemporaryPosition,
keyboardBehavior,
keyboardBlurBehavior,
]
);
const handleOnChange = useCallback(
function handleOnChange(index: number) {
Expand Down Expand Up @@ -1063,6 +1098,7 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
animatedHandleHeight,
animatedFooterHeight,
animatedKeyboardHeight,
animatedKeyboardHeightInContainer,
animatedContainerHeight,
animatedSnapPoints,
animatedHighestSnapPoint,
Expand All @@ -1079,7 +1115,6 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
failOffsetY: _providedFailOffsetY,
animateToPosition,
stopAnimation,
getKeyboardHeightInContainer,
setScrollableRef,
removeScrollableRef,
}),
Expand All @@ -1097,6 +1132,7 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
animatedAnimationState,
animatedKeyboardState,
animatedKeyboardHeight,
animatedKeyboardHeightInContainer,
animatedSheetState,
animatedHighestSnapPoint,
animatedScrollableState,
Expand All @@ -1117,7 +1153,6 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
_providedActiveOffsetY,
_providedFailOffsetX,
_providedFailOffsetY,
getKeyboardHeightInContainer,
setScrollableRef,
removeScrollableRef,
animateToPosition,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ const BottomSheetFooterContainerComponent = ({
animatedFooterHeight,
animatedPosition,
animatedKeyboardState,
getKeyboardHeightInContainer,
animatedKeyboardHeightInContainer,
} = useBottomSheetInternal();
//#endregion

//#region variables
const animatedFooterPosition = useDerivedValue(() => {
const keyboardHeight = getKeyboardHeightInContainer();
const keyboardHeight = animatedKeyboardHeightInContainer.value;
let footerTranslateY = Math.max(
0,
animatedContainerHeight.value - animatedPosition.value
Expand All @@ -37,12 +37,12 @@ const BottomSheetFooterContainerComponent = ({

return footerTranslateY;
}, [
animatedKeyboardHeightInContainer,
animatedContainerHeight,
animatedFooterHeight,
animatedHandleHeight,
animatedPosition,
animatedKeyboardState,
getKeyboardHeightInContainer,
animatedFooterHeight,
animatedHandleHeight,
]);
//#endregion

Expand Down
2 changes: 1 addition & 1 deletion src/contexts/internal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export interface BottomSheetInternalContextType
animatedFooterHeight: Animated.SharedValue<number>;
animatedHandleHeight: Animated.SharedValue<number>;
animatedKeyboardHeight: Animated.SharedValue<number>;
animatedKeyboardHeightInContainer: Animated.SharedValue<number>;
animatedScrollableType: Animated.SharedValue<SCROLLABLE_TYPE>;
animatedScrollableContentOffsetY: Animated.SharedValue<number>;
animatedScrollableOverrideState: Animated.SharedValue<SCROLLABLE_STATE>;
Expand All @@ -66,7 +67,6 @@ export interface BottomSheetInternalContextType
// methods
stopAnimation: () => void;
animateToPosition: AnimateToPositionType;
getKeyboardHeightInContainer: () => number;
setScrollableRef: (ref: ScrollableRef) => void;
removeScrollableRef: (ref: RefObject<Scrollable>) => void;
}
Expand Down