feat: add optional color for slide-toggle when unactivated #90

willdp · 2020-01-17T19:01:30Z

add optional color for slide0toggle when it is unactivated, also created
storybook for each case

add optional color for slide0toggle when it is unactivated, also created storybook for each case

DenisOkawa · 2020-01-17T19:40:23Z

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle.stories.ts

+        {
+        cod: "3",
+        checked: false,
+        title: "UNACTIVATE COLOR",


Shouldn't the title be 'Inactive'?

Or maybe 'unchecked', to keep consistency with component property

oliveira-gust · 2020-01-17T19:43:21Z

libs/shell/controls/src/lib/ui/slide-toggle/slide-toggle.component.ts

@@ -9,6 +9,7 @@ import { FormControl } from "@angular/forms";
 export class SlideToggleComponent implements OnInit {
  checked = true;
  colorFormControl = new FormControl("#08B25A");
+  uncheckedColorFormControl = new FormControl("#000000")


Also, please add the access modifier for these properties

oliveira-gust · 2020-01-17T19:46:09Z

libs/shell/controls/src/lib/ui/slide-toggle/slide-toggle.component.html

+          type="color"
+          placeholder="Unchecked Color"
+          [formControl]="uncheckedColorFormControl"
+        />


/> could be moved to the previous line

oliveira-gust · 2020-01-17T19:47:41Z

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle-group.component.html

          [title]="toggle?.title"
          (toggleChange)="toggleChange(toggle?.cod, $event)"
          ngDefaultControl
        ></gor-slide-toggle>
      </div>
    </ng-container>
  </div>
-</ng-container>
+</ng-container>


Missing newline at end of file

oliveira-gust · 2020-01-17T19:47:52Z

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle.component.html

      <span class="slider-before" [ngClass]="{ active: checked }"></span>
    </span>
  </label>
  <span class="title">{{ title }}</span>
-</div>
+</div>


Missing newline at end of file

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle.component.ts

oliveira-gust · 2020-01-17T19:54:12Z

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle.model.ts

   * @Optional
   */
  color?: string;
+
+


Please remove extra empty line

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle.model.ts

oliveira-gust · 2020-01-17T19:57:14Z

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle.stories.ts

+)
+.addDecorator(withKnobs)
+.add(
+    'three different cases about slide-toggle',


Summary should be descriptive of functionality being demonstrated - in this case, color configurations

oliveira-gust · 2020-01-17T19:58:20Z

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle.stories.ts

+storiesOf('slide-toggle', module)
+  .addDecorator(
+    moduleMetadata({
+        imports: [CommonModule],


Check if this import is necessary

oliveira-gust · 2020-01-17T19:59:43Z

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle.stories.ts

@@ -0,0 +1,74 @@
+import { storiesOf, moduleMetadata } from '@storybook/angular';


Nice stories, keep up the good work

oliveira-gust · 2020-01-17T20:00:17Z

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle.stories.ts

+        checked: false,
+        title: "UNACTIVATE COLOR",
+        color: "",
+        uncheckedColor: "#456888"


Check code identation in all this file

oliveira-gust · 2020-01-17T20:02:46Z

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle.stories.ts

+        {
+        cod: "3",
+        checked: false,
+        title: "UNACTIVATE COLOR",


Keep text capitalization consistent across titles

oliveira-gust · 2020-01-17T20:03:25Z

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle.stories.ts

+       >
+        </gor-slide-toggle>
+        `
+    }));


Missing newline at end of file

fix some sintax and identation erros, also add acess modifier for some properties

oliveira-gust · 2020-01-20T16:48:06Z

.prettierignore

@@ -4,3 +4,4 @@
 **/*.md
 **/*.scss
 **/*.html
+**/*.stories.ts


Missing newline at end of file

oliveira-gust · 2020-01-20T16:49:25Z

libs/shell/controls/src/lib/ui/slide-toggle/slide-toggle.component.ts

+  public colorFormControl = new FormControl('#08B25A');
+  public uncheckedColorFormControl = new FormControl('#000000');
+  public disabled = false;
+  public titleFormControl = new FormControl('click me');

  constructor() {}

  ngOnInit() {}


Empty methods can be removed

oliveira-gust · 2020-01-20T16:49:37Z

libs/shell/controls/src/lib/ui/slide-toggle/slide-toggle.component.ts

-  styleUrls: ["./slide-toggle.component.scss"]
+  selector: 'gorilainvest-slide-toggle',
+  templateUrl: './slide-toggle.component.html',
+  styleUrls: ['./slide-toggle.component.scss']
 })
 export class SlideToggleComponent implements OnInit {


OnInit interface can be removed

oliveira-gust · 2020-01-20T16:51:12Z

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle.stories.ts

+        {
+          cod: '3',
+          checked: false,
+          title: 'UNCHEKED COLOR',


Please correct typo in title

oliveira-gust · 2020-01-20T16:51:36Z

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle.stories.ts

+      const labels = ['title'];
+
+      return {
+


Remove extra empty line

oliveira-gust · 2020-01-20T16:51:48Z

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle.stories.ts

+              [labels]='${JSON.stringify(labels)}'
+          >
+          </gor-slide-toggle-group>
+    `


Check identation

guilhermejcgois

Nice job, thanks for this new feature! Just one little thing before we can go... Can you check story name? We don't use the component selector to name stories... Also, can you too check the plural of examples titles?

…mponents into feature/unchecked-color-slidetoggle

guilhermejcgois · 2020-02-10T02:26:07Z

Two more things before merge the PR:

Fix last commits author
Update branch

feat: add optional color for slide-toggle when unactivated

a4e74d8

add optional color for slide0toggle when it is unactivated, also created storybook for each case

willdp requested review from guilhermejcgois and ricalamino as code owners January 17, 2020 19:01

DenisOkawa reviewed Jan 17, 2020

View reviewed changes

oliveira-gust reviewed Jan 17, 2020

View reviewed changes

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle.component.ts Show resolved Hide resolved

oliveira-gust reviewed Jan 17, 2020

View reviewed changes

libs/ui-toolkit/slide-toggle/src/lib/slide-toggle.model.ts Show resolved Hide resolved

oliveira-gust reviewed Jan 17, 2020

View reviewed changes

refactor: fix some sintax and identation erros

b3388ad

fix some sintax and identation erros, also add acess modifier for some properties

oliveira-gust reviewed Jan 20, 2020

View reviewed changes

.prettierignore Outdated

@@ -4,3 +4,4 @@

**/*.md

**/*.scss

**/*.html

**/*.stories.ts

Copy link

Contributor

oliveira-gust Jan 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline at end of file

oliveira-gust reviewed Jan 20, 2020

View reviewed changes

refactor: fixing identation and sintax errors

d11f70c

oliveira-gust approved these changes Jan 20, 2020

View reviewed changes

refactor: removing extra empty line

d891178

guilhermejcgois suggested changes Jan 21, 2020

View reviewed changes

willdp added 2 commits January 27, 2020 14:37

refactor: change storybook name

0621d9f

Merge branch 'master' of https://github.com/gorilainvest/gorila-ui-co…

31a753e

…mponents into feature/unchecked-color-slidetoggle

guilhermejcgois approved these changes Feb 10, 2020

View reviewed changes

guilhermejcgois closed this Mar 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add optional color for slide-toggle when unactivated #90

feat: add optional color for slide-toggle when unactivated #90

willdp commented Jan 17, 2020

DenisOkawa Jan 17, 2020

oliveira-gust Jan 17, 2020

oliveira-gust Jan 17, 2020

oliveira-gust Jan 17, 2020

oliveira-gust Jan 17, 2020

oliveira-gust Jan 17, 2020

oliveira-gust Jan 17, 2020

oliveira-gust Jan 17, 2020

oliveira-gust Jan 17, 2020

oliveira-gust Jan 17, 2020

oliveira-gust Jan 17, 2020

oliveira-gust Jan 17, 2020 •

edited

Loading

oliveira-gust Jan 17, 2020

oliveira-gust Jan 17, 2020

oliveira-gust Jan 20, 2020

oliveira-gust Jan 20, 2020

oliveira-gust Jan 20, 2020

oliveira-gust Jan 20, 2020

oliveira-gust Jan 20, 2020

oliveira-gust Jan 20, 2020

guilhermejcgois left a comment

guilhermejcgois commented Feb 10, 2020

		@@ -0,0 +1,74 @@
		import { storiesOf, moduleMetadata } from '@storybook/angular';

feat: add optional color for slide-toggle when unactivated #90

feat: add optional color for slide-toggle when unactivated #90

Conversation

willdp commented Jan 17, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oliveira-gust Jan 17, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guilhermejcgois left a comment

Choose a reason for hiding this comment

guilhermejcgois commented Feb 10, 2020

oliveira-gust Jan 17, 2020 •

edited

Loading