Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding mods from GitHub releases reports "thread 'main' has overflowed its stack" #377

Closed
1 task done
tunaflsh opened this issue Sep 27, 2023 · 7 comments
Closed
1 task done

Adding mods from GitHub releases reports "thread 'main' has overflowed its stack" #377

tunaflsh opened this issue Sep 27, 2023 · 7 comments
Labels
bug Something doesn't work as expected fixed in source Bug has been fixed in source-code, but has not been released yet priority I'm working on it, or will be soon

Comments

@tunaflsh
Copy link

Description

For some GitHub releases adding the mod causes "thread 'main' has overlowed its stack." This message doesn't tell me anything to troubleshoot it.

Steps to reproduce

  1. Make sure you created a profile
  2. Run ferium add Nyan-Work/malilib --dont-check-mod-loader --dont-check-game-version
  3. Expect Adding mod... ✓, but instead
Adding mod...
thread 'main' has overflowed its stack

Operating System

Windows

Are you using the latest version of ferium?

  • I am using the latest version of ferium

Additional Information

ferium installed from Rust toolchain cargo install ferium.
@tunaflsh tunaflsh added the bug Something doesn't work as expected label Sep 27, 2023
@theRookieCoder theRookieCoder added the cannot replicate The bug cannot be replicated, or the enhancement already exists label Sep 27, 2023
@theRookieCoder
Copy link
Collaborator

Hmm I have no idea why this occurs. More importantly, I can't replicate this on my machine. Is this on x64 Windows or some other architecture?

@tunaflsh
Copy link
Author

I'm on Windows 11 64 bit. I was using msys2/mingw64 as a shell, but installed rust using rustup.

I just tried in the normal command prompt, same result.

@tunaflsh
Copy link
Author

Just tried the GNU binary for Windows from Releases. Same thing.

@theRookieCoder
Copy link
Collaborator

Thanks for the info. I don't have a working Windows installation, but I'll try debugging this in docker and see if I can replicate this.

@Neboer
Copy link

Neboer commented Apr 21, 2024

same here，if you execute ferium add 531834 in 1.20.1 forge environment, the bug will appear.

@theRookieCoder theRookieCoder added the priority I'm working on it, or will be soon label May 10, 2024
@theRookieCoder
Copy link
Collaborator

Ok I was able to reproduce this issue but I have no idea where the stack overflow is occuring because rust-lang/rust#51405. But I'll try to debug this nevertheless.

@theRookieCoder theRookieCoder removed the cannot replicate The bug cannot be replicated, or the enhancement already exists label Jun 1, 2024
@theRookieCoder theRookieCoder added the fixed in source Bug has been fixed in source-code, but has not been released yet label Jun 10, 2024
@theRookieCoder
Copy link
Collaborator

Fixed in gorilla-devs/libium@130055b

theRookieCoder added a commit that referenced this issue Jun 10, 2024
@theRookieCoder
Update CHANGELOG.md with #377
7816162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something doesn't work as expected fixed in source Bug has been fixed in source-code, but has not been released yet priority I'm working on it, or will be soon
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Neboer @theRookieCoder @tunaflsh