Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for sha256 uploads #50

Merged
merged 2 commits into from
May 8, 2022
Merged

Support for sha256 uploads #50

merged 2 commits into from
May 8, 2022

Conversation

JustSimplyKyle
Copy link
Contributor

Supports for Scoop.

@JustSimplyKyle JustSimplyKyle mentioned this pull request May 8, 2022
Closed
9 tasks
@theRookieCoder
Copy link
Collaborator

Does sha256sum exist? Isn't it shasum -a 256, or is this an alias on linux only?

@theRookieCoder
Copy link
Collaborator

Also the file should be added to ./out because that's where files are uploaded from

@JustSimplyKyle
Copy link
Contributor Author

sha256sum does exist on linux. and fixed it to added to out!

@theRookieCoder
Copy link
Collaborator

theRookieCoder commented May 8, 2022 •
edited

Great! We can test this on 3.28.1 soon. How do you test scoop packages? Is it done by the human reviewers?

@JustSimplyKyle
Copy link
Contributor Author

JustSimplyKyle commented May 8, 2022 •
edited

yeah, once they approve the package
It will be updated automatically(by action bot) every week

@theRookieCoder theRookieCoder merged commit 30aa384 into gorilla-devs:main May 8, 2022
@theRookieCoder
Copy link
Collaborator

Oh the file should be taken from the out directory too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JustSimplyKyle @theRookieCoder