First invocation breaks if user.email git config not set.

[rtimmons]

The CLI setup / ~/.gorilla-cli-useridcreation logic tries to call git config --global user.email:

gorilla-cli/go_cli.py

Line 81 in ec4153a

subprocess.check_output(["git", "config", "--global", "user.email"])

This can fail if the user hasn't configured this git-config value (or if the user doesn't have git installed).

This results in an exception, but we continue to write the cli-userid file anyway (it's empty at this point):

gorilla-cli/go_cli.py

Line 81 in ec4153a

subprocess.check_output(["git", "config", "--global", "user.email"])

Then on subsequent invocations, the (empty) cli-userid file is read, and this assertion block prevents progress without meaningful recourse:

gorilla-cli/go_cli.py

Line 76 in ec4153a

assert user_id != ""

Suggested fixes / ideas:

1. Allow the git config invocation to fail

   gorilla-cli/go_cli.py

   Line 81 in ec4153a

   subprocess.check_output(["git", "config", "--global", "user.email"])

   and do the uuid-based id generation logic there.
2. Rather than asserting the id to be non-empty

   gorilla-cli/go_cli.py

   Line 76 in ec4153a

   assert user_id != ""

   , either delete the file or prompt the user to do so.

Thanks for making this project and making it available open-source. I hope this bug report is helpful.

[rtimmons]

@aki-k beat me to it in #2 - please resolve this if easier for management.

[ShishirPatil]

Thank you @rtimmons and @aki-k If either of you are interested in a simple fix, even a try catch - please do raise a PR and I'd love to welcome you as a contributor!! 🎉

[dxxvi]

I know almost nothing about python. I got bit at this:

⮞ git config --global user.email
ava.lagoon@yahoo.com
⮞ my-python-venv/bin/gorilla "how to list all files in a directory"
Traceback (most recent call last):
  File "/home/ubuntu/my-python-venv/bin/gorilla", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/ubuntu/my-python-venv/lib/python3.11/site-packages/go_cli.py", line 128, in main
    user_id = get_user_id()
              ^^^^^^^^^^^^^
  File "/home/ubuntu/my-python-venv/lib/python3.11/site-packages/go_cli.py", line 76, in get_user_id
    assert user_id != ""
           ^^^^^^^^^^^^^
AssertionError

What should I do here?

[AshTreeSystems]

@dxxvi If you ran the command before setting the email try rm .gorilla-cli-userid and re-running the command.

[ShishirPatil]

+1 @AshTreeSystems is spot on. Just delete the file and run the command again to reinitialize it.