Add time precision parameter to ToAtom #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 25, 2018 14:07
Sometimes it's desirable to have millisecond precision on atom entries.
|
I'm open to adding this, but I don't think it should be in the form of a boolean argument. To allow for future extensibility we should probably define an |
|
Also, should similar functionality also be added to RSS and JSON feeds? |
|
Yeah, I was probably just too lazy to make it an options object. :-) I'll see if I find time to refactor it. Having this feature in RSS and JSON seems reasonable, too. |
|
I moved the precision parameter to the |
|
This issue has been automatically marked as stale because it hasn't seen a recent update. It'll be automatically closed in a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's desirable to have millisecond precision on atom entries.