Cleanup CompressHandlerLevel #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fharding1
commented
Nov 18, 2019
| break L | ||
| // detect what encoding to use | ||
| var encoding string | ||
| for _, curEnc := range strings.Split(r.Header.Get("Accept-Encoding"), ",") { |
There was a problem hiding this comment.
I know we could also setup the encWriter here, but I tried that and I think the code is more readable when this loop is only responsible for detecting the encoding.
elithrar
approved these changes
Nov 18, 2019
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nothing
Summary of Changes
Instead of having a labeled for loop that we can break to and having all the compression logic in that loop, make the loop responsible only for detecting the encoding, so that the important logic isn't nested deeply. Also updates some variable names for better readability.