compress: introduce CompressHandlerLevel #48
Conversation
| @@ -48,7 +57,7 @@ func CompressHandler(h http.Handler) http.Handler { | |||
| w.Header().Set("Content-Encoding", "gzip") | |||
| w.Header().Add("Vary", "Accept-Encoding") | |||
|
|
|||
| gw := gzip.NewWriter(w) | |||
| gw, _ := gzip.NewWriterLevel(w, level) | |||
There was a problem hiding this comment.
Instead of ignoring the error, we should check the level is within acceptable bounds, else we will run into undefined behaviour. If not, we should just set gzip.DefaultCompression as the level. Cover this in the function docs.
|
Thanks @flyingmutant! Are you able to address my comment and add a test to check that a |
|
Thanks for the review! Does it look OK now? |
|
@elithrar, any updates here? |
[feature] CompressHandler: introduce CompressHandlerLevel
|
Whoops, sorry @flyingmutant - missed this! Looks good to me: thanks for contributing 👍 |
|
One thing I wanted to add (for posterity): make sure to benchmark the CPU impact on the client (i.e. a mobile device!) when increasing compression. Slightly better compression over the wire may not be ideal in those cases. Using something like |
CompressHandlerLevelallows to specify a compression level explicitly. This allows clients to use e.g.gzip.BestCompression, which often results in major bandwidth savings.