FileStorage erase session fix #237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng a missing file
|
This issue has been automatically marked as stale because it hasn't seen a recent update. It'll be automatically closed in a few days. |
coreydaley
added a commit
that referenced
this pull request
Aug 17, 2023
#252) Summary of Changes Don't consider "oserror.ErrNotExist" as a failure when trying to erase a session which corresponds to a missing file. Hello, in the current implementation, if a request contains a session token that has been stored in a file that has been deleted and we're trying to erase it using the Options.MaxAge = -1 workaround, the action still fails, because the missing file error gets propagated higher in the stack. This small fix prevents this, and ensures that the session is regenerated. ___ This is a reopen of #237 which was closed by the stale bot. Co-authored-by: Corey Daley <cdaley@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Don't consider "oserror.ErrNotExist" as a failure when trying to erase a session which corresponds to a missing file.
Hello, in the current implementation if a request contains a session token that has been stored in a file that has been deleted the and we're trying to erase it using the
Options.MaxAge = -1workaround, the action still fails, because the missing file error gets propagated higher in the stack.This small fix prevents this, and ensures that the session is regenerated.
Please let me know if you have any feedback. Having this merged would help tremendously with one of the projects I'm working on.