We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In yesterday's v2 release I noticed two issues:
If an old package and a new package have the same import path, the new package must be backwards compatible with the old package.
When releasing v2 version of module it's recommended to also update module path. So I suppose it must be:
github.com/gorilla/websocket/v2
And tag is v2.0.0
websocket/go.mod
Line 1 in ac0789b
https://github.com/gorilla/websocket/tree/v2.0
I suppose this may cause issues with Go tooling.
Also, could you please tell why there is vendor directory appeared in repo root? It's quite strange to see it in 2023.
vendor
The text was updated successfully, but these errors were encountered:
Never used it myself, but probably may be useful - retract directive of go.mod
Sorry, something went wrong.
This should be fixed now, release of gorilla/websocket is v1.5.1
No branches or pull requests
Is there an existing issue for this?
Current Behavior
In yesterday's v2 release I noticed two issues:
Expected Behavior
When releasing v2 version of module it's recommended to also update module path. So I suppose it must be:
And tag is v2.0.0
Steps To Reproduce
websocket/go.mod
Line 1 in ac0789b
https://github.com/gorilla/websocket/tree/v2.0
Anything else?
I suppose this may cause issues with Go tooling.
Also, could you please tell why there is
vendor
directory appeared in repo root? It's quite strange to see it in 2023.The text was updated successfully, but these errors were encountered: