Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepared Messages #211

Merged
merged 7 commits into from
Feb 14, 2017
Merged

Prepared Messages #211

merged 7 commits into from
Feb 14, 2017

Conversation

garyburd
Copy link
Contributor

@garyburd garyburd commented Feb 6, 2017

No description provided.

@garyburd garyburd mentioned this pull request Feb 6, 2017
@garyburd
Copy link
Contributor Author

garyburd commented Feb 6, 2017

Work to be done:

  • Simplify or remove the benchmarks.
  • Pool the fake connection write buffer. Better yet, refactor connection code to eliminate use of fake connection.
  • Add autobahn test w/ prepared messages.

@FZambia
Copy link
Contributor

FZambia commented Feb 13, 2017

@garyburd waiting for feedback on what I've pushed.

Pool the fake connection write buffer.

Is it the same as #192 ? This looks like optimization but not a requirement.

Better yet, refactor connection code to eliminate use of fake connection.

Not sure I am ready to take over on this as it seems like dangerous refactoring if done by me:)

Simplify broadcast benchmarks, autobahn tests for prepared message
@garyburd garyburd merged commit 804cb60 into gorilla:master Feb 14, 2017
@garyburd
Copy link
Contributor Author

@FZambia Thank you for helping to get this done.

@gorilla gorilla locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants