[Feature] copy button on intro #17
Conversation
|
@samslow |
Could you be more specific? What other method can I use to support multiple languages? |
|
NOTE. That's just Question. not be related this PR. um.. current directory structure is as follows
yes. that's almost same structure If I update if we get each doc's language state, we can merge that two file i think. I thought it might have been intended, so I was wondering if you could explain it if you did. |
I know it. I'm just interested in the better way of managing a page supporting multiple languages. And I think reviewing your PR would also be done more smoothly after talking about it, since the way you dealt with multiple languages in your PR is different from the way I have been doing on this project.
In what way can we merge? Can you give me some guide, please?
I don't understand this sentence. What should I explain? |
Maybe you mean the option 4, while my current way of doing is option 2, on this stack overflow answer? |
Oh. that's good example. this project's way is Options 2 described as a nightmare. and my suggestion is not exist that stackoverflow. My way is to put a separate language pack file or enum and render it dynamically in a language state. For this, it would be easier for us to use frameworks such as React or Vue. But if we want more easy, we can make language file and one index.html ps. i think merge this PR first. And open another Issue for the discussion about language. |
Sorry for distraction, but, is there a link to a webpage or something which describes your method? |
|
i can't find any example link. So I just wrote it myself. // app.js
import Language from '../config/language'
const app = () => {
const currentLang = Language[getCurrentLang()] // "ko"
render(
<html>
...
<body>
<div>${currentLang.createRoom}</div>
<div>${currentLang.roomId}</div>
<div>${currentLang.copy}</div>
...
</body>
</html>
)
}// config/language.js
export default Language = {
ko:{
...,
"createRoom": "방 만들기",
"roomId": "방 ID",
"copy": "복사",
...
},
en:{
...,
"createRoom": "create room",
"roomId": "Room ID",
"copy": "Copy",
...
}
}But This is not complete example, i want you this code explain my way to you |
|
Thanks for your detailed explanation! Now I got something! I think if your code is rendered on the browser, then it is option 1 in the stack overflow answer. And if the html files are built from your code, then it is option 4 in the stack overflow answer. Is my understanding right? |
yes I think you can do that depending on anyone understanding. if you don't want add any framewrok and only want vanila, we can apply that in <script/> |
This reverts commit 86e8f65.
|
The revert commit is my mistake. It is not merged to branch master. |
i love it! good job! |
resolve #16
Add copy button on
create roombutton.if you click this, system write roomId on your clipboard.
Hello. this is my first PR on this game.
I tried to follow the conventions of the project as much as possible.
But if I'm lacking anything, please add comment. cause i'm a just student.
If I were you, I would have applied different languages to one file.