Make size ignore formatted cells without content #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 9, 2019
4 similar comments
houndci-bot
reviewed
Oct 9, 2019
|
I can roughly see where you are going. Let us discuss this in an issue #53 first so I understand it fully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a bunch of issues loading spreadsheets with formatting over "all" rows. The way it saves styles after your content is to have rows/columns with empty content, repeated a lot of times.
With 0.5.3, all my documents from gnumeric would respond with a rowcount of 65536 items, and documents with styles selecting a column would return 1048576 rows.
I made first_unused_subitem_index to look in a subset consisting from the first item to the last item with content. I also added another testfile and specs for worksheet.