Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handler.js to entrypoints #41

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

silvio2402
Copy link
Contributor

This change exposes the handler function (wrapper) to allow running custom servers.
Exposing a handler function directly like in the adapter-node package would be a potential improvement.
Resolves #28 and #37.

@catdadcode
Copy link

catdadcode commented Nov 24, 2023

I've gone ahead and merged this change into my fork at v0.5.6 in case you want to use it.

bun add -D @catdadcode/svelte-adapter-bun@0.5.6

https://github.com/catdadcode/svelte-adapter-bun

I plan to maintain this fork and contitnue to roll in updates from this repo.

@silvio2402
Copy link
Contributor Author

I've gone ahead and merged this change into my fork at v0.5.6 in case you want to use it.

@catdadcode thanks for your efforts. However it looks like the latest version of your NPM package @catdadcode/svelte-adapter-bun@0.5.6 doesn't include this commit: catdadcode/svelte-adapter-bun@9428ee9.

@catdadcode
Copy link

I've gone ahead and merged this change into my fork at v0.5.6 in case you want to use it.

@catdadcode thanks for your efforts. However it looks like the latest version of your NPM package @catdadcode/svelte-adapter-bun@0.5.6 doesn't include this commit: catdadcode/svelte-adapter-bun@9428ee9.

This should be remedied in 0.5.7. I believe I had forgotten to build before publish. Please let me know if you still have issues. Also make sure you're both updating the version in package.json and running bun install to install the updated version. I also added a "prepublish" script to ensure builds run whenever it's about to publish to the registry to help prevent me forgetting to do so after making changes.

@gornostay25 gornostay25 merged commit 0917b50 into gornostay25:master Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapter doesn't export "handler" like the other adapters
3 participants