Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mismatch parsed and output length on amd64 #2

Merged
merged 7 commits into from
Apr 23, 2024
Merged

Conversation

asdine
Copy link
Collaborator

@asdine asdine commented Jul 14, 2023

While parsing asm, goat panics if a function has an empty set of lines.

@asdine asdine requested a review from zhenghaoz July 14, 2023 13:39
@zhenghaoz
Copy link
Contributor

Could you add a test case for this PR under the tests folder. Thanks

@asdine asdine mentioned this pull request Jul 18, 2023
@asdine
Copy link
Collaborator Author

asdine commented Jul 18, 2023

Blocked by #7

@asdine asdine changed the title fix: avoid panic on empty lines when parsing amd64 assembly fix: mismatch parsed and output length Apr 5, 2024
@asdine
Copy link
Collaborator Author

asdine commented Apr 5, 2024

Fixes #7

@asdine asdine changed the title fix: mismatch parsed and output length fix: mismatch parsed and output length on amd64 Apr 5, 2024
@asdine
Copy link
Collaborator Author

asdine commented Apr 5, 2024

@zhenghaoz the PR is ready and fixes both the initial issue (the empty generated lines) and an issue about different output size on amd64

@asdine
Copy link
Collaborator Author

asdine commented Apr 23, 2024

@zhenghaoz The changes in this branch have been used in production at Weaviate for a few months now. Can I merge them and create a v0.2?

@asdine
Copy link
Collaborator Author

asdine commented Apr 23, 2024

@zhenghaoz If that's ok I will merge this PR as it dramatically improves the stability of Goat on amd64.
I have another one coming up that does the same for arm64, especially SVE instructions.
After that, I think we are ready for a v0.2.

Please let me know if you see any issue with that and I will undo it.

Thanks!

@asdine asdine merged commit 0e9e439 into main Apr 23, 2024
3 checks passed
@asdine asdine deleted the fix/empty-lines branch April 23, 2024 12:03
@zhenghaoz
Copy link
Contributor

@zhenghaoz If that's ok I will merge this PR as it dramatically improves the stability of Goat on amd64. I have another one coming up that does the same for arm64, especially SVE instructions. After that, I think we are ready for a v0.2.

Please let me know if you see any issue with that and I will undo it.

Thanks!

Thank you. Please release the version if you could. If you need more help, just let me know. 😁

@asdine
Copy link
Collaborator Author

asdine commented Apr 24, 2024

Thanks @zhenghaoz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants