Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support duplicate feedback #434

Open
martinlisaturn opened this issue Apr 19, 2022 · 4 comments
Open

Support duplicate feedback #434

martinlisaturn opened this issue Apr 19, 2022 · 4 comments

Comments

@martinlisaturn
Copy link

martinlisaturn commented Apr 19, 2022

Is your feature request related to a problem? Please describe.
Currently feedback must be unique of user_id,item_id,feedback_type. In our usecase we would like the model to take in to account the number of times the feedback was provided. eg: If an item was viewed multiple times.

Describe the solution you'd like
A clear and concise description of what you want to happen.
Multiple triads of user_id,item_id,feedback_type can be inserted as feedback.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

  • Multiple 'sub' feedback types eg 'viewed-1', 'viewed-2'

Additional context
Add any other context or screenshots about the feature request here.

@zhenghaoz
Copy link
Collaborator

There is two way to achieve this:

  1. Support duplicate feedback
  2. Add a count field into feedback.

I prefer the second one. Do you think the second one meets your situation?

@martinlisaturn
Copy link
Author

In the case of solution 2 I don't immediately see how a feedback TTL can be implemented.
It seems cleaner to have 1 row per feedback instance and have the existing TTL logic apply.

Having some sort of visibility into when feedback was given may also improve the recommendations

@zhenghaoz
Copy link
Collaborator

To be honest, the first one is easier to implement 😂 This feature is not easy to implement, it might be implemented several versions latter

@martinlisaturn
Copy link
Author

Can you shed some light on to where the complexity lies? I would love to improve my understanding of this problem !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants