client: don't use concurrency in agent.start

gortc · Aug 11, 2018 · 66fcc03 · 66fcc03
1 parent ee6a265
commit 66fcc03
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/client.go b/client.go
@@ -395,7 +395,6 @@ func (s *callbackWaitHandler) setCallback(f func(event Event)) {
 func (s *callbackWaitHandler) reset() {
 	s.processed = false
 	s.callback = nil
-	s.handler = nil
 }
 
 var callbackWaitHandlerPool = sync.Pool{

diff --git a/client_test.go b/client_test.go
@@ -712,12 +712,12 @@ func TestClientRetransmission(t *testing.T) {
 	agent.start = func(id [TransactionIDSize]byte, deadline time.Time) error {
 		if attempt == 0 {
 			attempt++
-			go agent.h(Event{
+			agent.h(Event{
 				TransactionID: id,
 				Error:         ErrTransactionTimeOut,
 			})
 		} else {
-			go agent.h(Event{
+			agent.h(Event{
 				TransactionID: id,
 				Message:       response,
 			})
@@ -733,6 +733,7 @@ func TestClientRetransmission(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
+	c.SetRTO(time.Second)
 	go func() {
 		buf := make([]byte, 1500)
 		readN, readErr := connL.Read(buf)