Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates Continous Integration Configuration for CircleCI #44

Merged
merged 6 commits into from Oct 29, 2018

Conversation

Lennox-of-Shippo
Copy link
Contributor

No description provided.

@assislucas
Copy link
Member

Hey Lennox could you fix or remove the bad tests so we can see the full CI flow?

@Lennox-of-Shippo
Copy link
Contributor Author

I will do that and let you know when its ready

@Lennox-of-Shippo
Copy link
Contributor Author

Deploy to nuget is working.
Ready for another review.

Copy link
Member

@assislucas assislucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's --recv-keys 3FA7E0328081BFF6A14DA29AA6 ? Is this sensitive information?

Copy link
Member

@assislucas assislucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you make the GitHub version push work?

@Lennox-of-Shippo
Copy link
Contributor Author

https://www.mono-project.com/download/stable/#download-lin

The keys are found here so likely public.

Github worked on ssh. I could edit the config to make it run a deploy job again.

@assislucas
Copy link
Member

@Lennox-of-Shippo Please do another full deploy then to confirm everything works and then I can approve

Copy link
Member

@assislucas assislucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@Lennox-of-Shippo Lennox-of-Shippo merged commit 0e9fb45 into master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants