Add Go modules support #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for vendorizing the dependencies through Go modules.
|
Hi, thank you for this change. I want to test this change locally but I just started my vacations and will not have access to my computer for minimum 8 days. Sorry. |
|
No worries, thank you! Enjoy your vacation! |
matrixik
approved these changes
Oct 19, 2019
|
Sorry it took me so long to merge it. Thank you. |
|
@matrixik No worries, thank you so much for taking the time to review and merge! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on implementing #37 I noticed that there were no Go module files.
This pull request adds the go.mod and go.sum to the project.
Thank you!