Add kazakh language #40
Conversation
|
Hi, thank you for adding new language. I left some comments inline. |
languages_substitution.go
Outdated
| 'ғ': "g", | ||
| 'һ': "h", | ||
| 'і': "i", | ||
| 'ң': "n", | ||
| 'ө': "o", | ||
| 'қ': "q", | ||
| 'ұ': "u", | ||
| 'ү': "u", |
There was a problem hiding this comment.
I'm a little confused. Do we really need all of them here? As far as I checked https://github.com/rainycape/unidecode/blob/master/table.txt almost all of them are already handled correctly.
The only difference I see you change қ to q and unidecode library is changing it to k. We can use your version here if it's better.
There was a problem hiding this comment.
Modern translation қ => q, so its correct
There was a problem hiding this comment.
without this additional subtitution ң converted to n- (and others )
There was a problem hiding this comment.
Oh, you are right. Don't know why I mentally removed - from them.
| '&': "jane", | ||
| 'ә': "a", |
There was a problem hiding this comment.
People don't use @ at Kazakh, that's why I used default @=>`` ( empty )
There was a problem hiding this comment.
This is strange for me. What about writing email address in text (like mail@example.com)?
Personally I would prefer handling @ but will merge it as is for now, and fix if someone complain.
languages_substitution.go
Outdated
| 'Ә': "A", | ||
| 'Ғ': "G", | ||
| 'Һ': "H", | ||
| 'І': "I", | ||
| 'Ң': "N", | ||
| 'Ө': "O", | ||
| 'Қ': "Q", | ||
| 'Ұ': "U", | ||
| 'Ү': "U", |
There was a problem hiding this comment.
Ups, they are ordered here by commenting order and not simply from top. This refer to comment that most of them are already handled correctly by unidecode library.
There was a problem hiding this comment.
without this additional subtitution ң converted to n- (and others )
|
Thank you for adding this language :-) |
Add kazakh language by usual rule and ISO