Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(track): Allows for tracks in stacked circular tracks to receive click events #1005

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

etowahadams
Copy link
Contributor

@etowahadams etowahadams commented Dec 5, 2023

Fix #992
Toward #

Change List

  • Allows for tracks in stacked circular tracks to receive click events by making circular masks for tracks with circular layouts

Demo

Screen.Recording.2023-12-05.at.10.40.51.AM.mov

Checklist

  • Ensure the PR works with all demos on the online editor
  • Unit tests added or updated
  • Examples added or updated
  • Documentation updated (e.g., added API functions)
  • Screenshots for visual changes (e.g., new encoding support or UI change on Editor)

@etowahadams etowahadams changed the title fix: circular mask for circular layout fix(track): circular mask for circular layout Dec 5, 2023
@etowahadams etowahadams changed the title fix(track): circular mask for circular layout fix(track): Allows for tracks in stacked circular tracks to receive click events Dec 5, 2023
Copy link
Member

@sehilyi sehilyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! I did not realize there is a setMask function to address this.

@etowahadams
Copy link
Contributor Author

It took me quite a while to figure out what to change, but once I did, it was a simple fix! Thanks for looking over this. Merging now.

@etowahadams etowahadams merged commit aea3a5d into master Dec 6, 2023
7 of 8 checks passed
@etowahadams etowahadams deleted the etowahadams/mouse-events branch December 6, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support mouse events in circular layouts of stacked tracks
2 participants