Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): export GoslingCompProps #1033

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

thomcsmits
Copy link
Collaborator

Exporting GoslingCompProps so that it can be accessed when using the Gosling library

Fix #
Toward #

Change List

Checklist

  • Ensure the PR works with all demos on the online editor
  • Unit tests added or updated
  • Examples added or updated
  • Documentation updated (e.g., added API functions)
  • Screenshots for visual changes (e.g., new encoding support or UI change on Editor)

Copy link
Member

@sehilyi sehilyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It is possible to get this type using React.ComponentPropsWithoutRef (below), but I think it does not hurt to have this exported explicitly.

type goslingCompoProps = React.ComponentPropsWithoutRef<typeof gosling.GoslingComponent>;

@sehilyi sehilyi merged commit e4091ae into main Jan 17, 2024
4 checks passed
@sehilyi sehilyi deleted the thomcsmits/export-goslingcompprops branch January 17, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants