Fixed read buffer size on GetBulk/Walk requests - fixes #45 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* GetBulk (aka Walk) performance improvements. GetBulk will require a large recv packet. The despatch call is now passed the expected PDU count rather than the request PDU count (which is always 1 on a GetBulk request) * Fixed an Windows OS problem/bug. A UDP read with a undersized buffer raises and error rather than truncates data. Added code to handle this case. * Minor comment to understand rxBufSizeMax (2 x standard MTU size).
|
ACK. Or more correctly, SYN-ACK :-) |
|
SNMP is UDP though.... I've hence just assumed you'd get back, and will just nag until you do :-) |
|
Thanks @codedance for all your work here. I fixed a spell-o and squashed be commits, then merged. FIN, I don't need no stinkin UDP :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #45 .
recv packet. The despatch call is now passed the expected PDU count
rather than the request PDU count (which is always 1 on a GetBulk request)
and error rather than truncates data. Added code to handle this case.