make the new code optional #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed drawing of O in aldehydes. * Added DrawColour::operator!=. * Remove unused variable. * Export doLinesIntersect for test. Co-authored-by: David Cosgrove <david@cozchemix.co.uk> Co-authored-by: Greg Landrum <greg.landrum@gmail.com>
* Make ACS mode work properly in fixed size drawers. * Extra comment. * Update hash codes. * Export doLinesIntersect. Co-authored-by: David Cosgrove <david@cozchemix.co.uk> Co-authored-by: Greg Landrum <greg.landrum@gmail.com>
…rdkit#5550) * Fixes rdkit#5505 * Switch to using hasBondTypeQuery() * update the docs * ensure we still fail with non-ring aromatic atoms * changes in response to review
* Fix crash in brackets extraction. * Add hashcode, tidy. * Remove unused variable. Co-authored-by: David Cosgrove <david@cozchemix.co.uk> Co-authored-by: Greg Landrum <greg.landrum@gmail.com>
* switch to basic cmake from external project the external project stuff in cmake is overly opaque * enable yaehmop builds in CI * disable building of the yaehmop binary * Update External/YAeHMOP/CMakeLists.txt Co-authored-by: Ric <ricrogz@users.noreply.github.com> Co-authored-by: Ric <ricrogz@users.noreply.github.com>
Co-authored-by: Sreya Gogineni <74024376+gosreya@users.noreply.github.com>
Good catch. It's fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a cmake configuration option for the new code so that building it is optional. I want to do this so that we don't add a mandatory dependency on the YAeHMOP code.
It also merges on the most recent status of master