Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update and more general wording for "docker container" #934

Merged
merged 8 commits into from
Jul 3, 2024

Conversation

dklimpel
Copy link
Contributor

@dklimpel dklimpel commented Jun 17, 2024

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

Fixes: #931


📚 Documentation preview 📚: https://goss--934.org.readthedocs.build/en/934/

@aelsabbahy
Copy link
Member

Thank you for submitting this.

Couple of feedbacks on this:

  1. Removing docker from kgoss and in a few other places makes sense. But this PR is a little aggressive and removes docker from everything. dgoss is a docker (and also podman) wrapper for goss, dcgoss is a docker-compose wrapper for Goss

  2. CI is failing, not sure why yet.

Copy link
Contributor Author

@dklimpel dklimpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2. CI is failing, not sure why yet.

The CI has problems with goss_int_test_alpine3_386. I think the CI is not reliable. Since the last successful run (a6451d2) there were only changes at documentation.

I will revert one change. Feel free to revert more or mark the positions.
IMO docker and podman are wrapper for container engines. And both runs container. There are no special docker containers.

README.md Outdated Show resolved Hide resolved
petemounce
petemounce previously approved these changes Jun 28, 2024
Copy link
Member

@aelsabbahy aelsabbahy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes, otherwise looks good.

@@ -9,7 +9,7 @@ containers. It is based on `dgoss`.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets revert the changes in this file, since it's dcgoss aka docker-compose goss.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

README.md Outdated
Also, user submitted wrapper scripts for Kubernetes [kgoss](https://github.com/goss-org/goss/tree/master/extras/kgoss)
and Docker Compose [dcgoss](https://github.com/goss-org/goss/tree/master/extras/dcgoss).

**Note:** For some Docker/Kubernetes healthcheck, health endpoint, and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blog post references docker, this line should be reverted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@aelsabbahy aelsabbahy merged commit b8ff782 into goss-org:master Jul 3, 2024
5 checks passed
@dklimpel dklimpel deleted the docs_fix_wording_docker branch July 3, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: "docker" container in kgoss docs
3 participants