Add a silent output #216
Merged
Add a silent output #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using goss as a helathchecking endpoint, it may be desirable to suppress verbose test output so that potential malicious entities can't scrape healthcheck endpoints for system information. Add the `silent` output, which simply checks whether any tests have failed and returns 1 or 0 accordingly, without printing any output.
|
Awesome! Code looks good, can you also update the documentation as part of this pull request. |
|
Oh of course! My bad. |
strongoose
force-pushed
the
silent-output
branch
from
b0e59fa
to
d47e701
Compare
|
I've added some one-line output descriptions. They're maybe a bit long, but I thought it was worth expanding on the use-case, since it's perhaps non-obvious. |
|
I'll merge/release with next release. Thanks 👍 |
BenjaminHerbert
pushed a commit
to BenjaminHerbert/goss
that referenced
this pull request
May 28, 2020
* Add a silent output When using goss as a helathchecking endpoint, it may be desirable to suppress verbose test output so that potential malicious entities can't scrape healthcheck endpoints for system information. Add the `silent` output, which simply checks whether any tests have failed and returns 1 or 0 accordingly, without printing any output. * Document silent output format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using goss as a helathchecking endpoint, it may be desirable to
suppress verbose test output so that potential malicious entities can't
scrape healthcheck endpoints for system information.
Add the
silentoutput, which simply checks whether any tests havefailed and returns 1 or 0 accordingly, without printing any output.