Increase buffer size #351
Merged
Increase buffer size #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's bump this to 1024, and I'll merge it. |
|
Buffer bumped to 1024. |
|
Thanks! |
BenjaminHerbert
pushed a commit
to BenjaminHerbert/goss
that referenced
this pull request
May 28, 2020
* Increase buffer size * Increase buffer to 1024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "fixes" #315 where big lines of test (like single line JSON) are not handled well by the default buffer size. This increases it from the default to 512K which should be enouch for most situations although this might warrant review / improvement in future.